Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Fixes: Custom API Auth headers in Paw + Postman Pathname Bug#141

Merged
mittsh merged 6 commits into
luckymarmot:developfrom
JonathanMontane:0002-luckymarmot
Nov 2, 2017
Merged

Fixes: Custom API Auth headers in Paw + Postman Pathname Bug#141
mittsh merged 6 commits into
luckymarmot:developfrom
JonathanMontane:0002-luckymarmot

Conversation

@JonathanMontane

Copy link
Copy Markdown
Contributor

@JonathanMontane

Copy link
Copy Markdown
Contributor Author

@JonathanMontane JonathanMontane changed the title added support for custom headers for api key auths Fixes: Custom API Auth headers in Paw + Postman Pathname Bug Sep 14, 2017
@JonathanMontane

Copy link
Copy Markdown
Contributor Author
  • fixes missing Postman imports in node, web and webworker
  • normalizes Postman format names to postman-collection

@JonathanMontane

Copy link
Copy Markdown
Contributor Author
  • loaders now default to fsResolution instead of httpResolution in case of unknown protocol
  • normalizes loaders behavior

@caffeineflo

Copy link
Copy Markdown

Hey @JonathanMontane,

thanks for getting back to me so quickly, I unfortunately wasn't that quickly testing your branch ... sorry!

Now that I finally got back to look into this, I tried reimporting the same Postman Collection again and I ended up getting a different error:

variable.createDynamicString is not a function. (In 'variable.createDynamicString()', 'variable.createDynamicString' is undefined)

@JonathanMontane

Copy link
Copy Markdown
Contributor Author

@caffeineflo I'm looking into what may be causing this issue.

Are you by any chance using the noauth authentication type in your collection? This might be what is causing issues. I'm looking into how to fix this.

@caffeineflo

Copy link
Copy Markdown

@JonathanMontane No noauth in my collection.

What I've been wondering, are you using any kind of new API-Flow version that I don't have access to? I've been searching through the API-Flow source and your code is the only one that uses variable.createDynamicString hence I'm wondering if I'm missing a commit that defines createDynamicString

@JonathanMontane

Copy link
Copy Markdown
Contributor Author

@caffeineflo createDynamicString is a method associated with variables that is exposed by Paw to the JS environment, which is why its definition is not inside the code (it's written in OBJ-C inside Paw).

I'll keep looking into what may be causing this bug then.

@caffeineflo

Copy link
Copy Markdown

Hey @JonathanMontane ,

I was wondering if there's anything I can do to help you debug this issue from my side?

@mittsh mittsh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works nicely. Thanks so much @JonathanMontane 👍

@caffeineflo thank you for the bug report! I have found and have been able to solve the bug (variable.createDynamicString is not a function). I'll do another PR for this one.

✌️

@mittsh mittsh merged commit 5bd2372 into luckymarmot:develop Nov 2, 2017
@mittsh

mittsh commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

@caffeineflo FYI I have fixed the bug in PR #143, I'll release a new Postman Importer and Swagger Importer shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apiKey securityDefinition is not respecting header key

3 participants