NN 134 - #7197
Merged
Merged
Conversation
Contributor
ChangelogFeatures
Bug fixes and improvements
Known issues
|
vadzim-vys
commented
May 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #7197 +/- ##
============================================
- Coverage 73.86% 73.86% -0.01%
Complexity 5982 5982
============================================
Files 813 813
Lines 31851 31853 +2
Branches 3793 3793
============================================
+ Hits 23527 23528 +1
- Misses 6821 6822 +1
Partials 1503 1503
|
vadzim-vys
commented
May 24, 2023
Comment on lines
+185
to
+189
| * The fact that the SDK triggers a callback on alternatives subscription I consider as a bug: | ||
| * 1. We recommend users to set updated alternatives back, and it doesn't make sense to trigger | ||
| * the callback with the same alternative as they are now. | ||
| * 2. The SDK doesn't trigger callback if routes were set already, so in general it feels | ||
| * inconsistent |
Contributor
Author
There was a problem hiding this comment.
@dzinad , @DzmitryFomchyn , can you please share your opinion about this SDK behaviour. Does it seem like a bug to you? Do you think I should open a ticket for this or it's better to solve it in this PR?
Contributor
There was a problem hiding this comment.
Agreed. I actually discussed the similar thing with NN and it seems like they shouldn't return alternatives, I'll send you the link in DM, could you verify if that's the same thing?
Contributor
There was a problem hiding this comment.
Sounds reasonable for me as well.
vadzim-vys
marked this pull request as ready for review
May 24, 2023 10:44
DzmitryFomchyn
approved these changes
May 24, 2023
vadzim-vys
added
the
needs backporting
vadzim-vys
added a commit
that referenced
this pull request
May 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.