Add app group support for iOS - #8
Merged
Merged
Conversation
Member
|
This LGTM! Still going to check with the other maintainers tomorrow, if we want to go for the Thanks for the PR! 馃殌馃コ |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
chrispader
requested changes
Jul 11, 2023
chrispader
requested changes
Jul 11, 2023
chrispader
left a comment
chrispader
left a comment
Member
There was a problem hiding this comment.
only one small change requested :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds app group support for iOS configurable via adding an
AppGroupkey toInfo.plistallowing sharing data between process in the same app group (e.g. with a share extension).This is the simplest solution but I outline some ways it could potentially be made more robust here. I'm happy to work on including anything from that outline as well should it seem useful.