fix: intersect OneOf and Equal choices in field2choices - #1069
Open
l46983284-cpu wants to merge 1 commit into
Open
fix: intersect OneOf and Equal choices in field2choices#1069l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
…llow-code#198) Calculate intersection across all choice validators (both validate.OneOf and validate.Equal) present on field.validators. Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198
When multiple choice validators are defined on a field (such as multiple
validate.OneOf, multiplevalidate.Equal, or a mix ofOneOfandEqual), the allowed choices should be the intersection of the values allowed by each validator.Previously:
validate.Equaloverrode any precedingvalidate.OneOfchoices.validate.Equalvalidators concatenated their values rather than intersecting them.Changes
validate.Equalcomparable values as single-element choice sets and intersect all choice sets viaOrderedSet.OneOf,OneOf+Equal, and multipleEqualvalidators (both intersecting and non-intersecting).