Describe the bug
The classes HelmholtzProblem and Advection contain unintended self references, which result in unexpected behavior during execution.
Details
- In
HelmholtzProblem, the method signature includes an extra self argument in forcing_term, which causes a mismatch when the method is called:
def forcing_term(self, input_):
This should likely omit self.
- In
Advection, the expression self.c is used within the equation method, but this reference introduces unintended behavior (unwanted changes of the attribute self.c)
Describe the bug
The classes
HelmholtzProblemandAdvectioncontain unintended self references, which result in unexpected behavior during execution.Details
HelmholtzProblem, the method signature includes an extra self argument inforcing_term, which causes a mismatch when the method is called:This should likely omit
self.Advection, the expressionself.cis used within the equation method, but this reference introduces unintended behavior (unwanted changes of the attributeself.c)