Conversation
dario-coscia
commented
Feb 9, 2024
dario-coscia
commented
Collaborator
- Unifying integral kernel NO architectures with BaseNO (maybe rename better)
- Implement FNO based on BaseNO
dario-coscia
added
pr-to-review
Member
|
Everything fine to me, please just fix the Codacy issues (https://app.codacy.com/gh/mathLab/PINA/pullRequest?prid=13602959) |
ndem0
reviewed
Feb 16, 2024
Comment on lines
+38
to
+57
| :param input_numb_fields: Number of input fields. | ||
| :type input_numb_fields: int | ||
| :param output_numb_fields: Number of output fields. | ||
| :type output_numb_fields: int | ||
| :param n_modes: Number of modes. | ||
| :type n_modes: int or list[int] | ||
| :param dimensions: Number of dimensions (1, 2, or 3). | ||
| :type dimensions: int | ||
| :param padding: Padding size, defaults to 8. | ||
| :type padding: int | ||
| :param padding_type: Type of padding, defaults to "constant". | ||
| :type padding_type: str | ||
| :param inner_size: Inner size, defaults to 20. | ||
| :type inner_size: int | ||
| :param n_layers: Number of layers, defaults to 2. | ||
| :type n_layers: int | ||
| :param func: Activation function, defaults to nn.Tanh. | ||
| :type func: torch.nn.Module | ||
| :param layers: List of layer sizes, defaults to None. | ||
| :type layers: list[int] |
Member
There was a problem hiding this comment.
for primitive type, use the compact form
Collaborator
Author
I tried to address as many as I could. The ones remaining are either not solvable (too many arguments in the input) or I do not know how to avoid triggering the codacy error (for example the forward pass one...). Also, I think the test failing on windows is due to the fact that some packages are not correctly installed when using windows... |
Member
|
Yes, just rebase conflicts after #243 and we're done! |
… it better) * Implement FNO based on BaseNO
* modify doc for FNO and adding for FourierIntegralKernel, NeuralKernelOperator * adding tests
Collaborator
Author
Should be done! |
AleDinve
pushed a commit
to AleDinve/PINA
that referenced
this pull request
Mar 4, 2024
* Unify integral kernel NO architectures with NeuralKernelOperator * Implement FNO based on NeuralKernelOperator * modify doc for FNO and add for FourierIntegralKernel, NeuralKernelOperator * adding tests --------- Co-authored-by: Dario Coscia <dariocoscia@Dario-Coscia.local> Co-authored-by: Dario Coscia <dariocoscia@dhcp-015.eduroam.sissa.it>
dario-coscia
added a commit
that referenced
this pull request
Mar 12, 2025
* Unify integral kernel NO architectures with NeuralKernelOperator * Implement FNO based on NeuralKernelOperator * modify doc for FNO and add for FourierIntegralKernel, NeuralKernelOperator * adding tests --------- Co-authored-by: Dario Coscia <dariocoscia@Dario-Coscia.local> Co-authored-by: Dario Coscia <dariocoscia@dhcp-015.eduroam.sissa.it>
dario-coscia
added a commit
that referenced
this pull request
Apr 17, 2025
* Unify integral kernel NO architectures with NeuralKernelOperator * Implement FNO based on NeuralKernelOperator * modify doc for FNO and add for FourierIntegralKernel, NeuralKernelOperator * adding tests --------- Co-authored-by: Dario Coscia <dariocoscia@Dario-Coscia.local> Co-authored-by: Dario Coscia <dariocoscia@dhcp-015.eduroam.sissa.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.