Skip to content

Expand email alias domain lists - #683

Open
faktas2 wants to merge 1 commit into
mainfrom
expand-email-alias-domains
Open

Expand email alias domain lists#683
faktas2 wants to merge 1 commit into
mainfrom
expand-email-alias-domains

Conversation

@faktas2

@faktas2 faktas2 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds two newly identified alias domains so more equivalent addresses
normalize to the same value before hashing:

  • fastmail.ca — Fastmail's own Canadian domain. Confirmed via MX
    records resolving to Fastmail's messagingengine.com infrastructure,
    and listed on Fastmail's official domain list.
  • myyahoo.com — an alternate Yahoo-owned signup domain (WHOIS
    registrant: Yahoo Assets LLC), functionally identical to yahoo.com.

Both run on their provider's own native mail platform with no
third-party migration history, so the existing normalization logic
applies to them exactly as it does to their canonical counterparts.

This mirrors the same addition made to the minFraud web service's own
email normalization.

Testing

Added matching unit test cases following the existing pattern. Not run
locally — no Maven available in this environment — so CI should be
checked before merge.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added support for recognizing additional Fastmail and Yahoo email domains during address normalization.
  • Bug Fixes

    • Improved normalization, domain extraction, and MD5 handling for aliases using the newly supported domains.

Add fastmail.ca to the Fastmail domain set and myyahoo.com to the
Yahoo domain set, so more equivalent addresses normalize to the same
value before hashing. Both are confirmed to run on their provider's
own mail platform with no third-party migration history.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c880691d-a141-41a5-8f86-6da1daf87ec7

📥 Commits

Reviewing files that changed from the base of the PR and between d5a605e and 155ee56.

📒 Files selected for processing (2)
  • src/main/java/com/maxmind/minfraud/request/Email.java
  • src/test/java/com/maxmind/minfraud/request/EmailTest.java

📝 Walkthrough

Walkthrough

The email domain allowlists now include fastmail.ca and myyahoo.com. Tests verify normalization, MD5 input, and domain extraction for addresses using those domains.

Changes

Email normalization

Layer / File(s) Summary
Domain mappings and normalization coverage
src/main/java/com/maxmind/minfraud/request/Email.java, src/test/java/com/maxmind/minfraud/request/EmailTest.java
Adds fastmail.ca and myyahoo.com to the relevant allowlists and verifies alias normalization, MD5 input, and domain extraction for both cases.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

I’m a rabbit with domains to sort,
Fastmail and Yahoo now join the court.
Aliases hop, hashes gleam,
Tests keep every address clean.
Satisfied ears: the mappings report!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: expanding email alias domain normalization lists.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch expand-email-alias-domains

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant