Fix useFind#370
Merged
Merged
Conversation
piotrpospiech
requested review from
CaptainN,
Grubba27,
henriquealbert and
radekmie
radekmie
approved these changes
Nov 9, 2022
Grubba27
reviewed
Nov 9, 2022
Grubba27
left a comment
Grubba27
left a comment
Contributor
There was a problem hiding this comment.
I think now looks good!
Can I merge & release? or you want to add those tests?
| }, | ||
| }) | ||
| observer.stop() | ||
| if (!(cursor instanceof Mongo.Cursor)) { |
Contributor
There was a problem hiding this comment.
This looks better than the previous version!
awesome work!
Grubba27
approved these changes
Nov 9, 2022
Contributor
Author
|
I can add tests in another PR in which I will fix the test environment. It can be merged and released. |
Contributor
|
Released 2.5.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #369
Data returned by
useFindwasn't updated if the cursor was changed. It happened because the initial fetch was called only once.I added the initial fetch also to the
useEffecthook. It will be called only if the cursor is updated.