Feature update mongo api#50
Closed
Grubba27 wants to merge 60 commits into
Closed
Conversation
henriquealbert
left a comment
henriquealbert
left a comment
Member
There was a problem hiding this comment.
Need to update the changelog, bump Meteor version, test on Cordova iOS and Android
Collaborator
|
@Grubba27 I think we can merge this, no? |
Grubba27
commented
Oct 2, 2023
Comment on lines
+20
to
+21
| const tasks = useTracker(async () => | ||
| await TasksCollection.find({}, { sort: { createdAt: -1 } }).fetchAsync() |
Contributor
Author
There was a problem hiding this comment.
I needed to stop this pr because useTracker could not handle async states at the time.
Now it can. We were planing on coming back on this one following the same style as the vue3 guide that was launched
Contributor
Author
|
I think before merging this I need to solve this issue that I pointed in this comment I would try adjusting this update alongside a slight visual update the same way @vit0rr did with the vue3 tutorial. |
Collaborator
|
@Grubba27 a friendly ping on this. |
Contributor
|
This is now updated in the V3 tutorial https://docs.meteor.com/tutorials/react/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry in advance for the number of changes :(
Should have to do step-by-step, but it seems to be a kind of easy one to review
This one will depend on this one to be merged and also on the newest version. could not proceed with testing it, but as soon new release is out I will come back to this one and check if there are any issues left