Skip to content

Feature/memprof under benchmark - #245

Merged
FranFin merged 6 commits into
masterfrom
feature/memprof_under_benchmark
Dec 2, 2020
Merged

Feature/memprof under benchmark#245
FranFin merged 6 commits into
masterfrom
feature/memprof_under_benchmark

Conversation

@FranFin

@FranFin FranFin commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

This PR groups the new sections into with the old benchmarking section has been split (concept and result) and the new memo_prof page under the same tab benchmarking.

ralph-lange
ralph-lange previously approved these changes Nov 24, 2020
@walkiry

walkiry commented Nov 25, 2020

Copy link
Copy Markdown

@FranFin Do you think it would be worth to mention, within the benchmarking results, the profiling results?

walkiry
walkiry previously approved these changes Nov 25, 2020
@FranFin

FranFin commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

@walkiry You mean just a sentence referring to the Memory Profiling page? That's fine with me!

Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
Comment thread _docs/concepts/benchmarking/benchmarking/index.md Outdated
pablogs9
pablogs9 previously approved these changes Nov 26, 2020
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
@amx-piap
amx-piap dismissed stale reviews from pablogs9, walkiry, and ralph-lange via 0ed7e6f November 27, 2020 05:27
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
amx-piap
amx-piap previously approved these changes Nov 27, 2020
@FranFin
FranFin merged commit 030d1ad into master Dec 2, 2020
@FranFin
FranFin deleted the feature/memprof_under_benchmark branch December 2, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants