Skip to content

Fix CI Badges size and other layout improvements - #255

Merged
jamoralp merged 3 commits into
masterfrom
feature/fix_CI_badges
Dec 22, 2020
Merged

Fix CI Badges size and other layout improvements#255
jamoralp merged 3 commits into
masterfrom
feature/fix_CI_badges

Conversation

@pablogs9

@pablogs9 pablogs9 commented Dec 4, 2020

Copy link
Copy Markdown
Member

TODO:

  • Try moving releases badges on the same column as repository name and see how the result looks like.
  • Move read the docs section onto final column, as it is not so important

jamoralp
jamoralp previously approved these changes Dec 4, 2020
@jamoralp jamoralp changed the title Fix CI Badges size Fix CI Badges size and other layout improvements Dec 4, 2020

@JanStaschulat JanStaschulat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.
However, the badge for CI is very short and the text is rather ugly shrinked.
Also the text of the other badges is squeezed and does not look very nice.

How about configuring the column width for those badge-columns to be large enough, that a normal badge icon would fit in?
Or adding empty spaces in the header row of the table - so that that badge columns have the same size?

Also (at least with my local jekyll server) I cannot click on rclc:Foxy release icon. Only if I zoom in very much, than the icon is click-able. Do you have the same problems, or does the link work for you?

@jamoralp

jamoralp commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Looks fine to me.
However, the badge for CI is very short and the text is rather ugly shrinked.
Also the text of the other badges is squeezed and does not look very nice.

Well, this is what happens in the version that is currently uploaded to the webpage server: https://micro-ros.github.io/docs/overview/docker_ci_status/

However, in this branch, if I build the webpage on my laptop, then enter the link, it looks like this:
Screenshot from 2020-12-04 11-34-14
which is fine in my opinion.

Also (at least with my local jekyll server) I cannot click on rclc:Foxy release icon. Only if I zoom in very much, than the icon is click-able. Do you have the same problems, or does the link work for you?

In my local generated page, the icon is clickable and looks ok IMO. Both eloquent and foxy badges redirect to micro-ROS/rclc:master GitHub repository

@ralph-lange

Copy link
Copy Markdown
Contributor

I just tested the branch locally with Jekyll: All badges have the same height now, but they are still squeezed so that the content becomes unreadable. Given the many white areas in each row, I still think that we should reduce the number of columns by putting some information (e.g., issues and PRs) in one cell vertically. Also, 5mm are lost just because of the column header "Documentation", which is wider than the read-the-docs badges.

@ralph-lange

Copy link
Copy Markdown
Contributor

grafik

@jamoralp
jamoralp merged commit 5509277 into master Dec 22, 2020
@jamoralp
jamoralp deleted the feature/fix_CI_badges branch December 22, 2020 14:48
@ralph-lange

Copy link
Copy Markdown
Contributor

Some badges are still a bit squeezed, but it is much better now. Thank you!

grafik

The squeezing of the CI badges can probably be removed by simply replacing "CI" with "Continuous\n Integration" in the table header.

@jamoralp

Copy link
Copy Markdown
Contributor

Some badges are still a bit squeezed, but it is much better now. Thank you!

grafik

The squeezing of the CI badges can probably be removed by simply replacing "CI" with "Continuous\n Integration" in the table header.

That is weird, and definitely not happening on my browser (Google Chrome on Linux Mint). Anyway, if the problem persist changing the title could be the solution, yes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants