fix: continue importing remaining URLs on failure in import-url command#435
Open
A-d-i-t-y wants to merge 1 commit into
Open
fix: continue importing remaining URLs on failure in import-url command#435A-d-i-t-y wants to merge 1 commit into
A-d-i-t-y wants to merge 1 commit into
Conversation
Previously the import-url command would exit immediately on the first failed URL, leaving remaining URLs unprocessed. Now all URLs are attempted regardless of individual failures and a non-zero exit code is returned only if any import failed. Closes microcks#399 Signed-off-by: Aditya <aaaditya1909@gmail.com>
Author
|
Hi @Harsh4902 @Vaishnav88sk, I have raised this PR to fix the early exit bug in import-url command as discussed in issue #399. Same fix as PR #394 for the import command - all URLs are now attempted regardless of individual failures. Would love your feedback! |
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix early exit bug in import-url command when importing multiple URLs.
Problem
When running:
microcks import-url "https://url1.yaml,https://url2.yaml,https://url3.yaml"
If url1 fails, os.Exit(1) is called immediately and url2, url3
are never imported. Same bug as #393 which was fixed in import
command via PR #394.
Fix
Example output after fix
Failed to import 'https://url2.yaml': connection refused
Microcks has discovered 'https://url1.yaml'
Microcks has discovered 'https://url3.yaml'
Files Changed
Closes #399