refactor(config): remove unused ConfigPath package variable#445
Open
hazelmayank wants to merge 1 commit into
Open
refactor(config): remove unused ConfigPath package variable#445hazelmayank wants to merge 1 commit into
hazelmayank wants to merge 1 commit into
Conversation
Signed-off-by: hazelmayank <mayankjeefinal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused package-level
ConfigPathvariable frompkg/config/config.goalong with the
path/filepathimport it was the sole user of.Fixes #444 .
Background
pkg/config/config.godeclared:This variable is never read anywhere in the repo. A grep for
config.ConfigPath\breturns no matches — every apparent hit resolves to the unrelated
ConfigPathfield on the
ClientOptionsstruct (opts.ConfigPath/globalClientOpts.ConfigPath).The actual default config path the CLI uses comes from
DefaultLocalConfigPath()in
pkg/config/localconfig.go, which usesos.UserHomeDir()— thecross-platform-safe API.
If anything ever did start reading
config.ConfigPath, it would silently breakon Windows:
os.Getenv("HOME")returns""on a vanilla Windows install(Windows uses
USERPROFILE), producing a broken relative path like\.microcks-cli\config.yaml.Changes
pkg/config/config.go:ConfigPathvariable.path/filepathimport (only used by the removed variable).Test plan
go build .passes.microcks --helpandmicrocks contextstill resolve the config pathcorrectly (via
DefaultLocalConfigPath()inlocalconfig.go).