Chapter 10: MicroProfile JWT#25
Merged
Merged
Conversation
Content for Chapter 10: MicroProfile JWT
This was referenced Mar 21, 2025
Contributor
Author
|
@Emily-Jiang - This chapter is ready for merging; I have updated it with all the review feedback that I received so far. |
Member
|
@sberyozkin can you please review this PR |
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
reviewed
Apr 11, 2025
sberyozkin
left a comment
sberyozkin
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good.
I proposed a few more updates.
Thanks
rhusar
suggested changes
Apr 16, 2025
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
rephrase sentence for clarity Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
As advised, replacing an RS256 signed token from JWT spec appendixes.
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Radoslav Husar <radosoft@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Contributor
Author
Thanks, @sberyozkin, for your valuable feedback. I have now updated the post as per all your inputs. |
Contributor
Author
|
@Emily-Jiang - Please merge this PR as all the review feedbacks have been incorporated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content for Chapter 10: MicroProfile JWT