Skip to content

Chapter 11: MicroProfile Rest Client#26

Merged
Emily-Jiang merged 11 commits into
microprofile:mainfrom
ttelang:patch-13
Apr 28, 2025
Merged

Chapter 11: MicroProfile Rest Client#26
Emily-Jiang merged 11 commits into
microprofile:mainfrom
ttelang:patch-13

Conversation

@ttelang

@ttelang ttelang commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Content for Chapter 11: MicroProfile Rest Client

ttelang added 3 commits March 21, 2025 15:22
initial few sections.
chapter 11: MicroProfile Rest Client
@ttelang

ttelang commented Mar 21, 2025

Copy link
Copy Markdown
Contributor Author

I would be adding a section on RestClientBuilder and how to obtain a proxy (instance) of the rest client.

ttelang added 2 commits April 1, 2025 10:57
…e in Chapter 11

- Introduced programmatic client creation using RestClientBuilder
- Added InventoryService example calling ProductService with RestClientBuilder
- Explained builder pattern usage and method chaining benefits
- Clarified when to prefer programmatic client creation over CDI
- Included summary and key takeaways on MicroProfile Rest Client advantages
Adding a closing statement to the MicroProfile tutorial.
@ttelang

ttelang commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

I would be adding a section on RestClientBuilder and how to obtain a proxy (instance) of the rest client.

Done.

@ttelang

ttelang commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

@Emily-Jiang - This chapter is ready to merge as all the review feedback has been resolved. Please take care.

@Emily-Jiang

Copy link
Copy Markdown
Member

reviewing in progress

@jamezp jamezp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

One thing I wonder. Should we be using attributes for the spec names and versions? For example should we have:

:rest-client-spec-name: MicroProfile Rest Client
:rest-client-spec-version: 4.0

Comment thread chapter 11/index.adoc Outdated
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc Outdated
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc Outdated
Comment thread chapter 11/index.adoc
Comment thread chapter 11/index.adoc Outdated
Comment thread chapter 11/index.adoc Outdated
ttelang and others added 3 commits April 27, 2025 10:28
@ttelang

ttelang commented Apr 27, 2025

Copy link
Copy Markdown
Contributor Author

Just some minor comments.

One thing I wonder. Should we be using attributes for the spec names and versions? For example should we have:

:rest-client-spec-name: MicroProfile Rest Client
:rest-client-spec-version: 4.0

Updated.

@ttelang

ttelang commented Apr 27, 2025

Copy link
Copy Markdown
Contributor Author

@Emily-Jiang Please merge this PR, as all the review feedback has been incorporated. Thanks @rhusar and @jamezp for your valuable feedbacks.

@rhusar

rhusar commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@Emily-Jiang Please merge this PR, as all the review feedback has been incorporated. Thanks @rhusar and @jamezp for your valuable feedbacks.

@ttelang One last nitpick - the directory/file in this PR - chapter 11/index.adoc is named with a space, but the rest of the repository (https://github.com/microprofile/microprofile-tutorial) is naming the directories without a space.

@Emily-Jiang Emily-Jiang merged commit 53f617c into microprofile:main Apr 28, 2025
@rhusar

rhusar commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

@Emily-Jiang Please merge this PR, as all the review feedback has been incorporated. Thanks @rhusar and @jamezp for your valuable feedbacks.

@ttelang One last nitpick - the directory/file in this PR - chapter 11/index.adoc is named with a space, but the rest of the repository (https://github.com/microprofile/microprofile-tutorial) is naming the directories without a space.

Here's the PR fix for that - #29 - since this chapter is now listed at the top which might be confusing to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants