Skip to content

Disable new metrics packages & bump RPM builder#229

Open
pmtk wants to merge 3 commits into
microshift-io:mainfrom
pmtk:bump-builder-fix-rpm
Open

Disable new metrics packages & bump RPM builder#229
pmtk wants to merge 3 commits into
microshift-io:mainfrom
pmtk:bump-builder-fix-rpm

Conversation

@pmtk

@pmtk pmtk commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Build and Packaging
    • Updated the RPM build environment to CentOS Stream 10.
    • Improved image packaging by excluding unsupported metrics components, including metrics server, node exporter, and kube-state metrics packages.

@pmtk
pmtk requested a review from a team as a code owner July 24, 2026 12:35
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@pmtk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b801d235-7b96-440d-b2ac-bd4c2122f4e8

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3e1c5 and 006fc54.

📒 Files selected for processing (4)
  • docs/build.md
  • packaging/rpm.Containerfile
  • src/image/modify-spec.py
  • src/rpm/create_repos.sh
📝 Walkthrough

Walkthrough

The RPM build image moves to CentOS Stream 10. Downstream image specification filtering now removes additional metrics packages and install entries.

Changes

RPM build image

Layer / File(s) Summary
CentOS Stream 10 build base
packaging/rpm.Containerfile
The RPM build stage base image changes from CentOS Stream 9 to CentOS Stream 10.

Downstream spec filtering

Layer / File(s) Summary
Metrics package and install filtering
src/image/modify-spec.py
Package removal lists now include metrics packages and install keywords for kube-state-metrics and node-exporter.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: ggiguash

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: disabling new metrics packages and updating the RPM builder image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packaging/rpm.Containerfile`:
- Line 3: Update the RPM build documentation describing the make rpm target to
reference the CentOS Stream 10 builder instead of Stream 9. Review the Stream 10
release/test instructions in docs/build.md and ensure they explicitly cover
supported CentOS 9 deployments where required, without changing the packaging
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d7583d9-7131-42c9-80b9-0aa06924a6d0

📥 Commits

Reviewing files that changed from the base of the PR and between 99d9d3f and 6c3e1c5.

📒 Files selected for processing (2)
  • packaging/rpm.Containerfile
  • src/image/modify-spec.py

Comment thread packaging/rpm.Containerfile
@pmtk
pmtk force-pushed the bump-builder-fix-rpm branch from ee4ebad to 006fc54 Compare July 24, 2026 13:26
FROM localhost/microshift-okd-srpm:latest AS srpm

FROM quay.io/centos/centos:stream9
FROM quay.io/centos/centos:stream10

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still support CentOS 9, so I'm afraid upgrading to 10 for build might not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants