DOC: Architecture Responsibilities#2089
Merged
rlundeen2 merged 14 commits intoJun 30, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restructure framework.md to clearly define each component's responsibilities using an Owns / Does NOT own template, fix structural inconsistencies, and correct typos. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reorder and rename the landing-page cards to match the Core Components / Core library section order, add an Attack Techniques card, and drop the Attacks-and-Executors / Setup-and-Configuration labels in favor of the section names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds a Framework Documentation card and links the section header to the notebooks contributing guide, treating it as a Core library item. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rters Clarify that an attack may use defaults but should always accept its scorers, datasets/seeds (prepended_conversation and next_message), objective/adversarial targets, and converters as parameters so it can be packaged as an attack technique. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a Core library Backend section (presentation-specific REST API; reuse pyrit.models and the registry). Add a Source path line to every component section so the doc can be pointed at for code reviews. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
reviewed
Jun 27, 2026
romanlutz
approved these changes
Jun 27, 2026
romanlutz
left a comment
Contributor
There was a problem hiding this comment.
I am 100% in favor of these changes. The comments may improve/add things here and there but even as is it's a huge improvement.
…ture Bring framework.md fully up to date: top-down Core Components ordering, renamed Shared Library and new Application surfaces sections, normalized terminology (Scorers, Targets, seeds, Executors and Attacks), nesting hierarchy diagram, expanded 'Does not own' boundaries, header links, and matching Responsibility lines in the converter/dataset/models/target instruction guides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Output's printers fetch result data from CentralMemory to render it; the module never writes to memory. Reverse the OUT->MEM edge to MEM->OUT and label it 'reads' to reflect the actual data dependency. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scenarios return results; they don't render them. The entry points (Scanner/CLI, GUI/Backend, Framework/Notebooks) invoke Output to display results, pulling the data from Memory. Re-point the render edge from entry points instead of Scenario. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… responsibilities in review Reference doc/code/framework.md as the canonical architecture/responsibility guide, and make 'each component owns only its job' the top code-review priority (flag responsibility bleed between bricks). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a 'Does not own' note pointing to framework.md in the pluggable-brick instruction files (converters, datasets, targets, scorers, attacks, scenarios, output) so responsibility bleed is flagged during review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
enabled auto-merge
June 30, 2026 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the Architecture portion of
doc/code/framework.mdto clearly define each component's responsibilities