Skip to content

DOC: Architecture Responsibilities#2089

Merged
rlundeen2 merged 14 commits into
microsoft:mainfrom
rlundeen2:rlundeen2-framework-architecture-doc
Jun 30, 2026
Merged

DOC: Architecture Responsibilities#2089
rlundeen2 merged 14 commits into
microsoft:mainfrom
rlundeen2:rlundeen2-framework-architecture-doc

Conversation

@rlundeen2

@rlundeen2 rlundeen2 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Restructures the Architecture portion of doc/code/framework.md to clearly define each component's responsibilities

rlundeen2 and others added 6 commits June 26, 2026 16:31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restructure framework.md to clearly define each component's responsibilities using an Owns / Does NOT own template, fix structural inconsistencies, and correct typos.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reorder and rename the landing-page cards to match the Core Components / Core library section order, add an Attack Techniques card, and drop the Attacks-and-Executors / Setup-and-Configuration labels in favor of the section names.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds a Framework Documentation card and links the section header to the notebooks contributing guide, treating it as a Core library item.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rters

Clarify that an attack may use defaults but should always accept its scorers, datasets/seeds (prepended_conversation and next_message), objective/adversarial targets, and converters as parameters so it can be packaged as an attack technique.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a Core library Backend section (presentation-specific REST API; reuse pyrit.models and the registry). Add a Source path line to every component section so the doc can be pointed at for code reviews.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated
Comment thread doc/code/framework.md Outdated

@romanlutz romanlutz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 100% in favor of these changes. The comments may improve/add things here and there but even as is it's a huge improvement.

rlundeen2 and others added 6 commits June 30, 2026 14:35
…ture

Bring framework.md fully up to date: top-down Core Components ordering,
renamed Shared Library and new Application surfaces sections, normalized
terminology (Scorers, Targets, seeds, Executors and Attacks), nesting
hierarchy diagram, expanded 'Does not own' boundaries, header links, and
matching Responsibility lines in the converter/dataset/models/target
instruction guides.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Output's printers fetch result data from CentralMemory to render it; the
module never writes to memory. Reverse the OUT->MEM edge to MEM->OUT and
label it 'reads' to reflect the actual data dependency.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scenarios return results; they don't render them. The entry points
(Scanner/CLI, GUI/Backend, Framework/Notebooks) invoke Output to display
results, pulling the data from Memory. Re-point the render edge from
entry points instead of Scenario.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2 and others added 2 commits June 30, 2026 14:56
… responsibilities in review

Reference doc/code/framework.md as the canonical architecture/responsibility
guide, and make 'each component owns only its job' the top code-review
priority (flag responsibility bleed between bricks).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a 'Does not own' note pointing to framework.md in the pluggable-brick
instruction files (converters, datasets, targets, scorers, attacks,
scenarios, output) so responsibility bleed is flagged during review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rlundeen2
rlundeen2 enabled auto-merge June 30, 2026 22:04
@rlundeen2
rlundeen2 added this pull request to the merge queue Jun 30, 2026
Merged via the queue into microsoft:main with commit c8418c9 Jun 30, 2026
53 checks passed
@rlundeen2
rlundeen2 deleted the rlundeen2-framework-architecture-doc branch June 30, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants