FIX: Propagate dataset_name to jailbreak template seeds#2208
Merged
romanlutz merged 3 commits intoJul 17, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52d2518d-ebe5-4888-8189-6146b6503448
adrian-gavrila
approved these changes
Jul 16, 2026
…ilbreak-dataset-name # Conflicts: # doc/code/datasets/1_loading_datasets.ipynb
romanlutz
enabled auto-merge
July 17, 2026 03:37
romanlutz
pushed a commit
to romanlutz/PyRIT
that referenced
this pull request
Jul 20, 2026
Merge latest origin/main (27d20ee). Resolutions: - 26 A-G split-owned code/test files reset to origin/main (now covered by PRs microsoft#2208-2214), so this branch carries no production-code duplication. - matrix_atomic_attack_builder(.py/test) taken from main (orphaned core refactor does not belong on a notebook-validation branch). - Executed notebook .ipynb outputs kept from this branch (regenerated next). Result vs main: notebooks + notebook-source hardening + docs + frontend e2e only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52d2518d-ebe5-4888-8189-6146b6503448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jailbreak template seeds loaded by
_JailbreakTemplatesDataset._load_seedswere previously created without adataset_name, unlike seeds from other dataset providers. That left loaded jailbreak templates unattributed, so they could not be traced back to their source dataset once stored or queried in memory.This sets
seed.dataset_name = self.dataset_nameon each template seed as it is loaded, so jailbreak template seeds carry the samedataset_name(jailbreak_templates) as the dataset they come from. The change is a one-line addition inside the existing load loop and does not alter loading, skip-on-invalid, or ordering behavior.Tests and Documentation
test_fetch_dataset_async_loads_templates_from_pathto assert every loaded seed'sdataset_namematches the dataset'sdataset_name. The fulltests/unit/datasets/test_jailbreak_dataset.pysuite passes (8 passed).doc/code/datasets/1_loading_datasets.py(jupytext --execute --set-kernel python3 --to notebook); it executes cleanly with no error outputs, and the regenerated1_loading_datasets.ipynbis included in this PR.