feature: SR865 driver#242
Conversation
|
I think you can copy most of the functionality from the SR830 driver in #139 that is nearly complete. |
|
@alexcjohnson updated strings to numbers. Anything else to fix? |
| class Stanford_SR865(VisaInstrument): | ||
| """ | ||
| This is the code for Stanford_SR865 Lock-in Amplifier | ||
| Status: writing in progress |
There was a problem hiding this comment.
Status can be upgraded - beta perhaps, until it's seen use in an experiment?
@giulioungaretti you've made the point that first lines like this are pretty useless and I agree - but is there anything specific you'd like to see there instead?
There was a problem hiding this comment.
Though call, maybe nothing at all just if anything status, quirks and so on ?
There was a problem hiding this comment.
@alexcjohnson I have pushed the latest version.
| if mode in ['a', 'a-b']: | ||
| self.sensitivity.set_validator(self._VOLT_ENUM) | ||
| self._set_units('V') | ||
| else: |
There was a problem hiding this comment.
Do you ever enter these else blocks? Up above you are only define a and a-b. Some other lockins can do voltage or current, does this one?
|
Issues
======
+ Solved 1
- Added 2
Complexity increasing per file
==============================
- qcodes/instrument_drivers/stanford_research/SR865.py 2
Clones added
============
- qcodes/instrument_drivers/stanford_research/SR865.py 17
See the complete overview on Codacy |
| units='s', | ||
| get_cmd='OFLT?', | ||
| set_cmd='OFLT {}', | ||
| val_mapping={1e-6: 0, 3e-6: 1, |
There was a problem hiding this comment.
|
@alexcjohnson ok so this is the current version for SR865 what I have. Anything out of ordinary or I can merge? |
|
@alexcjohnson dancer? :) |
|
💃 |
5 participants
Changes proposed in this pull request :
SR865
@alexcjohnson @Rubenknex @MerlinSmiles
work in progress. Sensitivity and time_constant issues are the same as with SR830.