beta driver for Keithley and docstrings#69
Conversation
| self._trigger_sent = False | ||
|
|
||
| # Add parameters to wrapper | ||
| self.add_parameter('mode', get_cmd=':CONF?', get_parser=lambda x: x.strip().strip('"'), set_cmd=':CONF:{}', vals=StringValidator() ) |
There was a problem hiding this comment.
can you wrap these to 80 chars for readability?
There was a problem hiding this comment.
btw I see the wrapping below in the commented-out section, that I gather someone else wrote and you're just porting - just wanted to point out that it doesn't use the Python standard wrapping, which is to align with the opening paren inside which you're wrapping.
| flags=Instrument.FLAG_GETSET, | ||
| units='s', minval=0.001, maxval=99999.999, type=float) | ||
| self.add_parameter('readval', flags=Instrument.FLAG_GET, | ||
| units='AU', |
There was a problem hiding this comment.
@eendebakpt I noticed you use 'AU' for arbitrary units, I am using 'a.u.' in my drivers. I don't really care about which we use but I guess it's better to be consistent.
|
adding my 2 cents, @AdriaanRol @eendebakpt |
|
@damazter , I couldn't resist following your link. I think especially the reasoning why AU and a.u. should not be used makes sense.
Let's stick to "arb.unit" |
|
@eendebakpt I think the driver file should be renamed to fit the actual instrument and not the (previous?) company name |
|
@eendebakpt I did some linting and fixed a bug with the parameter docstring - it needed a separate form for the composite parameter case (multiple names etc). This is good to go from my standpoint - thanks for all the other little changes! 💃 |
6 participants
No description provided.