Add translation-bench gold-action validation helper - #2859
Merged
Dominic Nguyen (datduyng) merged 8 commits intoAug 13, 2026
Conversation
- Restore required empty parameters after placeholder stripping - Inject required single-literal string-union fields before validateAction - Export the helper from the synthesizer barrel
Dominic Nguyen (datduyng)
marked this pull request as ready for review
August 12, 2026 21:40
Tal Zaccai (TalZaccai)
requested changes
Aug 12, 2026
Address review feedback on the gold-action validation helper: - Call the helper from generationCandidate and benchmark validation paths - Resolve type-reference aliases before injecting single-literal fields - Add unit coverage next to goldParameterHygiene
Tal Zaccai (TalZaccai)
approved these changes
Aug 12, 2026
Dominic Nguyen (datduyng)
enabled auto-merge
August 12, 2026 22:28
Dominic Nguyen (datduyng)
removed this pull request from the merge queue due to a manual request
Aug 12, 2026
Dominic Nguyen (datduyng)
removed this pull request from the merge queue due to a manual request
Aug 12, 2026
Dominic Nguyen (datduyng)
removed this pull request from the merge queue due to a manual request
Aug 12, 2026
# Conflicts: # ts/packages/benchmarks/README.AUTOGEN.md
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate gold actions after restoring required empty parameters and single-literal union fields.