Skip to content

Support HTMLElement.hidden value "until-found"#1670

Open
pje wants to merge 3 commits into
microsoft:mainfrom
pje:pje/add-hidden-until-found
Open

Support HTMLElement.hidden value "until-found"#1670
pje wants to merge 3 commits into
microsoft:mainfrom
pje:pje/add-hidden-until-found

Conversation

@pje

@pje pje commented Jan 4, 2024

Copy link
Copy Markdown

HTMLElement.hidden can now be any of true | false | "until-found". (MDN)

This has support from two major browsers (Chrome and Edge). (caniuse)

Screen Shot 2024-01-03 at 19 08 05 Screen Shot 2024-01-03 at 19 07 00

@github-actions

github-actions Bot commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@pje

pje commented Jan 4, 2024

Copy link
Copy Markdown
Author
@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@HolgerJeromin

Copy link
Copy Markdown
Contributor

This has support from two major browsers (Chrome and Edge). (caniuse)

We need support from two major engines. Chrome and Edge are using both the blink engine.

@pje

pje commented Jan 4, 2024

Copy link
Copy Markdown
Author

We need support from two major engines.

Ah yes, I misread that clause in the readme!

In that case this isn't mergeable yet.

@saschanaz

Copy link
Copy Markdown
Contributor

@laymonage

Copy link
Copy Markdown
Contributor

I have rebased this in #2254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants