Skip to content

Allow v5 as peerDependency in ata package#2977

Merged
jakebailey merged 4 commits into
microsoft:v2from
curran:patch-1
Jun 4, 2024
Merged

Allow v5 as peerDependency in ata package#2977
jakebailey merged 4 commits into
microsoft:v2from
curran:patch-1

Conversation

@curran

@curran curran commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

One small step towards #2807

See comment #2807

Should in theory solve downstream issue vizhub-studio/vzcode#352

Comment thread packages/ata/package.json Outdated

@curran curran left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I removed the upper bound.

Comment thread packages/ata/package.json Outdated
@curran

curran commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

CI failed.
image

It looks like I need to yarn install to update the lockfile, as part of the PR. Sorry about that!

@jakebailey jakebailey closed this Jun 2, 2024
@jakebailey jakebailey reopened this Jun 2, 2024
@curran

curran commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@curran

curran commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for taking this over the finish line! Much appreciated.

@jakebailey
jakebailey merged commit 7691811 into microsoft:v2 Jun 4, 2024
@typescript-bot typescript-bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants