Skip to content

.call selects the wrong overload for String.prototype.replace #29789

@ljharb

Description

@ljharb

TypeScript Version: v3.3.1 and v3.4.0-dev.20190206

Search Terms: call replace overload

Code

String.prototype.replace.call(
    'one string',
    /a/g,
    'two string', // this line errors
);

It's worth noting that this is in a JS file, not a TS file, but I'm using allowJs and checkJs.

Expected behavior:
No error.

Actual behavior:
errors with error TS2345: Argument of type '"two string"' is not assignable to parameter of type '(substring: string, ...args: any[]) => string'

Playground Link: http://www.typescriptlang.org/play/#src=String.prototype.replace.call(%0D%0A%20%20%20%20'one%20string'%2C%0D%0A%20%20%20%20%2Fa%2Fg%2C%0D%0A%20%20%20%20'two%20string'%2C%0D%0A)%3B but the error doesn't seem to show up there.

Related Issues: no

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptHelp WantedYou can do this

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions