URL is missing from Window interface

[xtuc]

From PR #3741

[mhegazy]

@zhengbli can you take a look

[xtuc]

I'm trying to help but that's the only thing I can do. The Window Interface is in the dom.generated.d.ts source file: https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L11848. I can't find the way to create the URL object.

[zhengbli]

According to https://developer.mozilla.org/en-US/docs/Web/API/Window/URL:

It is good practice to call the URL constructor instead of using this property.

we should add a constructor for interface URL too. It may look like this:

interface URL {
    createObjectURL(object: any, options?: ObjectURLOptions): string;
    revokeObjectURL(url: string): void;
}

declare var URL: {
    prototype: URL;
    new(): URL;
}

Then for window, add:

interface window ... {
    ...
    URL: URL 
    ...
}

[xtuc]

The URL interface is already created: https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L10773-L10776 but it isn't instantiated.

[zhengbli]

Actually after trying out on various browsers, we found that the constructor of interface URL is not supported in both IE and Spartan. Therefore I think it is safer now to just add the property to window without changing the URL interface.