Allow settings.json to configure tssdk without a prompt

[eagarwal-notion]

Extension Version

Latest

VS Code Version

Latest

Operating system Version

Macos

Steps to reproduce

N/A

Issue

In our repository, we have a custom tsdk we'd like to use. While it's possible for us to configure one in the vscode settings files, but users need to accept the prompt before using it.

Would it be possible to add a setting in settings.json that always opts a user into using the workspace's tsdk and skips the prompt?

[RyanCavanaugh]

This has security implications (tsdk is effectively an arbitrary command), so it's necessary for the user to opt in.

[rubenferreira97]

Ryan Cavanaugh (@RyanCavanaugh) Wouldn't VS Code Workspace Trust be the right security boundary here?

The TypeScript extension already requires a trusted workspace because a workspace TSDK can execute workspace-controlled code. Once the user has trusted the workspace, requiring a second TSDK-specific opt-in seems redundant.

AFAIK other extensions follow this model. For example, Oxc allows workspace settings to configure executable paths and restricts those settings in untrusted workspaces. Once the workspace is trusted, it uses them without another prompt.

Could js/ts.tsdk.path work the same way: ignore it in untrusted workspaces, but automatically honor it in trusted ones?

[RyanCavanaugh]

Dirk Bäumer (@dbaeumer) what do you think?

[dbaeumer]

Binding it to workspace trust is fine. We do that in other situations as well (e.g. linter plug-ins, ....)