Test for action description of code actions, and simplify description for extracting method to file#18030
Merged
4 commits merged intoAug 25, 2017
Merged
Conversation
… for extracting method to file
ghost
force-pushed
the
extract-method-action-description
branch
from
August 24, 2017 21:17
484dc22 to
a7e7388
Compare
amcasey
reviewed
Aug 24, 2017
| this.raiseError(`verifyApplicableRefactorAvailableForRange failed - expected a refactor but found none.`); | ||
| } | ||
| if (refactors.length > 1) { | ||
| this.raiseError(`2 available refactors both have name ${name} and action ${actionName}`); |
Member
There was a problem hiding this comment.
Consider using the actual number.
amcasey
reviewed
Aug 24, 2017
| } | ||
| else if (isSourceFile(scope)) { | ||
| return `file '${scope.fileName}'`; | ||
| return "this file"; |
Member
There was a problem hiding this comment.
What about "file scope" or "top-level scope"?
Author
There was a problem hiding this comment.
Maybe this should be "global scope" for a global and "module scope" for a module? @DanielRosenwasser thoughts?
Member
|
FYI @RyanCavanaugh |
RyanCavanaugh
approved these changes
Aug 25, 2017
ghost
deleted the
extract-method-action-description
branch
August 25, 2017 16:53
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2017
… for extracting method to file (#18030) * Test for action description of code actions, and simplify description for extracting method to file * Add unit test file missing from tsconfig.json (only affects gulp) and update tests * Use the actual number * Use "module scope" or "global scope" instead of "this file"
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2017
… for extracting method to file (#18030) (#18044) * Test for action description of code actions, and simplify description for extracting method to file * Add unit test file missing from tsconfig.json (only affects gulp) and update tests * Use the actual number * Use "module scope" or "global scope" instead of "this file"
ghost
restored the
extract-method-action-description
branch
December 11, 2017 16:22
ghost
deleted the
extract-method-action-description
branch
December 11, 2017 16:23
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17998