Fix isTypeOfExpression in compiler API (#20875). - #20884
Merged
Merged
Conversation
Member
|
(Apparently that is not true?) |
Contributor
|
thanks Philippe Voinov (@tehwalris)! |
Albert Siddhartha Slawinski (errendir)
added a commit
to errendir/TypeScript
that referenced
this pull request
Jan 20, 2018
* origin/master: (134 commits) Fix isTypeOfExpression in compiler API (microsoft#20875). (microsoft#20884) add completion filter for function like body (microsoft#21257) Make nonnull assertions and binding patterns apparent declared type locations (microsoft#20995) For `{ type: "a" } | { type: "b" }`, find references for the union property (microsoft#21298) configureNightly -> configurePrerelease Create a 'configure-insiders' and 'publish-insiders' task. Add createProgram on WatchCompilerHost in goToDefinition, use array helpers and clean up code (microsoft#21304) Support testing definition range of a reference gruop (microsoft#21302) Handle `undefined` input to firstDefined (microsoft#21300) Avoid spreading array (microsoft#21291) LEGO: check in for master to temporary branch. Accept new baselines Add regression test Properly handle contravariant inferences in inferReverseMappedType Remove unused properties from interface Refactor (microsoft#21286) LEGO: check in for master to temporary branch. Fold newline logic into getNewLineOrDefaultFromHost External test runner updates (microsoft#21276) Report more detailed info during script debug failure ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20875. Does it make sense to write a test for this sort of change? If yes, could someone point me towards a similar trivial test against the public API?