Inference of string literals to keyof creates an object with props of type any, not {} - #21271
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoJan 19, 2018
Conversation
Nathan Shively-Sanders (sandersn)
requested a review
from Mohamed Hegazy (mhegazy)
January 18, 2018 16:53
Mohamed Hegazy (mhegazy)
approved these changes
Jan 19, 2018
Nathan Shively-Sanders (sandersn)
deleted the
infer-keyof-to-any-not-empty
branch
January 19, 2018 21:35
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to change it to
anybefore merging #19227. Thanks to Herrington Darkholme (@HerringtonDarkholme) for noticing this before it went out this way in the official 2.7 release.