Harden Extract Symbol against symbols without declarations - #21845
Merged
Conversation
Andrew Casey (amcasey)
requested review from
a user and
Ryan Cavanaugh (RyanCavanaugh)
February 9, 2018 22:50
|
Maybe |
Member
Author
|
Ryan Cavanaugh (@RyanCavanaugh) suggested it would be prudent not to change |
Andrew Casey (amcasey)
force-pushed
the
GH21793
branch
from
February 10, 2018 02:57
8a0713b to
0860b94
Compare
Member
Author
|
Mohamed Hegazy (@mhegazy) Shall I port this to 2.7? |
Andrew Casey (amcasey)
force-pushed
the
GH21793
branch
from
February 10, 2018 03:43
0860b94 to
e65a1a4
Compare
Contributor
|
We have kept all the telemetry crash report fixes to 2.8. unless there is another reason why you want it in 2.7, i would just keep it in 2.8. |
Mohamed Hegazy (mhegazy)
approved these changes
Feb 10, 2018
Deleted user (ghost)
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21793