Fix #4260 : Allow arguments that accept void to be omitted - #27506
Fix #4260 : Allow arguments that accept void to be omitted#27506Jack Williams (jack-williams) wants to merge 4 commits into
Conversation
|
TypeScript Bot (@typescript-bot) test this |
|
Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at f3b6eea. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Ryan Cavanaugh (@RyanCavanaugh) There were some upstream changes that affected the error messages so I merged master to get the new baselines; I don’t know if this had any impact on the RWC. Not a huge fan of having intermediate broken commits, and a merge, in the history. Tomorrow I might reopen this with a new PR that has a tidy history. |
|
Ryan Cavanaugh (@RyanCavanaugh) Closing in favour of #27522 (If I was better with git I could probably rebase through the merge commit, but sadly, I'm not). Please mark as irrelevant/invalid. |
Fixes #4260
Not sure if this behaviour is still desired anymore, but I thought I'd at least put this out there to try out.
I tried doing a fix that worked for generic types:
but things went horribly wrong, mostly because you have to defer the check until after instantiation and it messes with overload resolution. In the end it really didn't seem worth it.