No constraint for { [P in K]: XXX } where K is type variable - #28170
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoOct 26, 2018
Conversation
Member
Author
|
TypeScript Bot (@typescript-bot) test this. |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 30d1ecd. You can monitor the build here. It should now contribute to this PR's status checks. |
Member
Author
|
Looked over the RWC baseline changes. There are new errors in one project, all of which are correct and relate to uses of |
Anders Hejlsberg (ahejlsberg)
requested review from
Nathan Shively-Sanders (sandersn) and
Wesley Wigham (weswigham)
October 26, 2018 22:34
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 26, 2018
Anders Hejlsberg (ahejlsberg)
deleted the
fixGenericMappedTypeConstraint
branch
October 26, 2018 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following currently produces no errors:
That's obviously not right. This PR removes the code that gets this wrong in
resolveMappedTypeMembers.