Revert over-eager bailout when trimming trailing whitespace - #28848
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoDec 4, 2018
Conversation
Nathan Shively-Sanders (sandersn)
requested review from
Jesse Trinity (jessetrinity) and
Sheetal Nandi (sheetalkamat)
December 4, 2018 19:09
Nathan Shively-Sanders (sandersn)
changed the title
Sheetal Nandi (sheetalkamat)
approved these changes
Dec 4, 2018
Nathan Shively-Sanders (sandersn)
deleted the
fix-format-trailing-whitespace
branch
December 4, 2018 20:45
Nathan Shively-Sanders (sandersn)
added a commit
that referenced
this pull request
Dec 4, 2018
Member
Author
|
I also ported this to 3.2 since it should ship with the version of 3.2 that ships with VS. |
Jesse Trinity (jessetrinity)
left a comment
Jesse Trinity (jessetrinity)
left a comment
Contributor
There was a problem hiding this comment.
Discovering test is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken by #27978, which removed the fallback. Before that change, if formatting processed no ranges, then trimTrailingWhitespacesForRemainingRange would instead use the original range. During the development of #27978, I thought it was necessary to instead skip trimming when no ranges were processed. This turns out to be wrong, so this PR reinstates the original behaviour.
Fixes #28781