Skip to content

Defer switch exhaustiveness checks - #35000

Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fewerExhaustivenessChecks
Nov 9, 2019
Merged

Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fewerExhaustivenessChecks

Conversation

@ahejlsberg

Copy link
Copy Markdown
Member

Fixes the issue reported here: #34840 (comment).

@ahejlsberg

Copy link
Copy Markdown
Member Author

Ryan Cavanaugh (@RyanCavanaugh) Wesley Wigham (@weswigham) We might consider cherry picking this for 3.7.3.

@weswigham

Copy link
Copy Markdown
Member

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized community code test suite on this PR at be5d09e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham Wesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User suite diff is same as master and DT failures look unrelated, so seems good.

@RyanCavanaugh

Copy link
Copy Markdown
Member

Anders Hejlsberg (@ahejlsberg) does this also fix #34960?

@weswigham

Copy link
Copy Markdown
Member

Based on this exchange in the other PR, I'm guessing yes?

@ahejlsberg

Copy link
Copy Markdown
Member Author

Yes, this fixes #34960.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants