Revert "Revert #37106" - #38216
Closed
Daniel Rosenwasser (DanielRosenwasser) wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Chatted with Nathan Shively-Sanders (@sandersn) - it sounds like per discussion in #38168, we need some special exemption for |
Nathan Shively-Sanders (sandersn)
added
the
For Milestone Bug
Member
|
Nathan Shively-Sanders (@sandersn) is this waiting on work form you or Daniel Rosenwasser (@DanielRosenwasser) ? I don't think there's much for me to review here right now (that I didn't already look over once when it was first merged before being reverted for want of less breakiness). |
Daniel Rosenwasser (DanielRosenwasser)
deleted the
revert-38172-revert37106
branch
August 27, 2020 22:11
TypeScript Bot (typescript-bot)
added
For Uncommitted Bug
Member
Author
|
Might as well add a new PR, but worth reinvestigating if Nathan Shively-Sanders (@sandersn) remembers anything special that we need to re-introduce |
Member
|
I think #39637 superceded this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #38172