Add refactor convertToOptionalChainExpression - #39135

Merged

Jesse Trinity (jessetrinity) merged 49 commits into

microsoft:masterfrom

jessetrinity:refactorOptionalChain

Jul 14, 2020

Commits on Jun 18, 2020

add convertOptionalChain
Jesse Trinity
committed
77a49c3
cover more cases
Jesse Trinity
committed
9cf07cf
expose containsMatchingReference
Jesse Trinity
committed
80bf5d1
clean up performing edits
Jesse Trinity
committed
4e64236
bound start position
Jesse Trinity
committed
9a59e13
add tests
Jesse Trinity
committed
6c1bccf
refactor and handle edge cases
Jesse Trinity
committed
2a355e4
update tests
Jesse Trinity
committed
3dac9c6
consider explicit requests for empty spans
Jesse Trinity
committed
b403037
update fourslash to use trigger reason
Jesse Trinity
committed
1ae5500
add tests cases for trigger reason
Jesse Trinity
committed
bf28673
fix errors
Jesse Trinity
committed
fa3f9c8
remove type assertion
Jesse Trinity
committed
8794154
fix non ampersand chains
Jesse Trinity
committed
3d8fed1
clean up some logic
Jesse Trinity
committed
b5c833c

Commits on Jun 20, 2020

add ternary case
Jesse Trinity
committed
796b2bf
add diagnostic message
Jesse Trinity
committed
37004b7
resolve merge conflict
Jesse Trinity
committed
3584bae

Commits on Jun 22, 2020

Merge remote-tracking branch 'upstream/master' into refactorOptionalChain
Jesse Trinity
committed
1b2e86b
add nullish check for ternary expressions
Jesse Trinity
committed
afb0e44
Update src/services/refactors/convertToOptionalChainExpression.ts

Jesse Trinity (jessetrinity)
and
Nathan Shively-Sanders (sandersn)
authored
65ca81e
Update src/services/refactors/convertToOptionalChainExpression.ts

Jesse Trinity (jessetrinity)
and
Nathan Shively-Sanders (sandersn)
authored
d9c34ff
Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason3.ts

Jesse Trinity (jessetrinity)
and
Nathan Shively-Sanders (sandersn)
authored
c2b9924
Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason1.ts

Jesse Trinity (jessetrinity)
and
Nathan Shively-Sanders (sandersn)
authored
1d51dab
reformat and remove unused checks
Jesse Trinity
committed
adbd586

Commits on Jun 23, 2020

allow any for ternary refactor
Jesse Trinity
committed
fb6b831
add tests
Jesse Trinity
committed
8184ecf
add tests
Jesse Trinity
committed
5ac29a0
check return and variable statements
Jesse Trinity
committed
a0708be
use isMatchingReference instead of containsMatchingReference
Jesse Trinity
committed
6810cea
allow partial selections
Jesse Trinity
committed
5634a4c

Commits on Jun 24, 2020

fine tune selection ranges
Jesse Trinity
committed
e6e54cb
recurse for call expressions
Jesse Trinity
committed
77f47e7
fix spellings
Jesse Trinity
committed
1ba5fd0

Commits on Jun 25, 2020

add recursive cases
Jesse Trinity
committed
6095e95

Commits on Jun 26, 2020

remove isOrContainsMatchingReference
Jesse Trinity
committed
89c8c9d
cleanup
Jesse Trinity
committed
b20cd95

Commits on Jun 29, 2020

more refactoring
Jesse Trinity
committed
15176b2
cleanup
Jesse Trinity
committed
2de5e28
rename tests
Jesse Trinity
committed
4126a46

Commits on Jul 1, 2020

address PR comments
Jesse Trinity
committed
8f65c02
Merge remote-tracking branch 'upstream/master' into refactorOptionalChain
Jesse Trinity
committed
d4f6f52

Commits on Jul 2, 2020

check match syntactically
Jesse Trinity
committed
8aed315

Commits on Jul 7, 2020

handle another call expression case
Jesse Trinity
committed
602075f
some renames
Jesse Trinity
committed
a4cc060
inline some checks
Jesse Trinity
committed
e89ae08
add test
Jesse Trinity
committed
2cdb5e1

Commits on Jul 13, 2020

address comments
Jesse Trinity
committed
fd64b14
add refactorNotAvailableReason
Jesse Trinity
committed
01854bb