Skip to content

performanceTimestamp: use performance.now on node - #40590

Merged
Eli Barzilay (elibarzilay) merged 1 commit into
microsoft:masterfrom
elibarzilay:nanosec-timestamp
Oct 15, 2020
Merged

performanceTimestamp: use performance.now on node#40590
Eli Barzilay (elibarzilay) merged 1 commit into
microsoft:masterfrom
elibarzilay:nanosec-timestamp

Conversation

@elibarzilay

@elibarzilay Eli Barzilay (elibarzilay) commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

On node, performance is found in require("perf_hooks").

Fixes #40591.

@j-oliveras

Copy link
Copy Markdown
Contributor

Probably #40593 make this obsolete.

@elibarzilay

Copy link
Copy Markdown
Contributor Author

Probably #40593 make this obsolete.

Indeed it does, the question is to do this specific thing in case #40593 will get merged later.

@typescript-bot TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 30, 2020
On node, `performance` is found in `require("perf_hooks")`.
@elibarzilay
Eli Barzilay (elibarzilay) merged commit 868638a into microsoft:master Oct 15, 2020
@elibarzilay
Eli Barzilay (elibarzilay) deleted the nanosec-timestamp branch October 15, 2020 23:02
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Backlog Bug PRs that fix a backlog bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

performanceTimestamp should use performance.now on node too

5 participants