Plain JS grammar errors - #47067
Merged
Merged
Conversation
From the list in #45349 (comment), excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows up a *lot* in plain JS.
Nathan Shively-Sanders (sandersn)
requested review from
Daniel Rosenwasser (DanielRosenwasser),
Andrew Casey (amcasey) and
Andrew Branch (andrewbranch)
and removed request for
Andrew Branch (andrewbranch)
December 8, 2021 16:26
Member
Author
|
Matt Bierner (@mjbvz) You are probably interested in this as well. |
Also remove checkGrammarArguments; it's blocked entirely by the same parser error.
Andrew Branch (andrewbranch)
approved these changes
Dec 8, 2021
Member
Author
|
From discussion in the editors meeting, VS is the only editor we looked at that itself skips semantic errors from JS. So it'll need a code change to take advantage of this PR. |
Nathan Shively-Sanders (sandersn)
added a commit
that referenced
this pull request
Dec 9, 2021
Martin Probst (mprobst)
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Plain JS grammar errors From the list in microsoft#45349 (comment), excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows up a *lot* in plain JS. * Add grammarErrorAtPos errors Also remove checkGrammarArguments; it's blocked entirely by the same parser error.
Martin Probst (mprobst)
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
These are the last ones that I know of. They come from calls to `grammarErrorOnFirstToken`. Fixes part of microsoft#45349 Follow-up to microsoft#47067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These errors result in syntax errors in JS, making them useful for the editor to display.
From the list at #45349 (comment),
excluding the JSX errors, decorator errors and unresolved #private error. The latter re-uses "Cannot resolve name X" which naturally shows
up a lot in plain JS.
Follow-up to #46816 which covers binder errors.
This list is the 56 errors out of the 184 calls to
grammarErrorOnNode, which is an arbitrary way to split up the work. I'll cover the rest of the grammar errors in a follow-up PR.Edit: I added the 7 errors from grammarErrorAtPos. This revealed that checkGrammarArguments' only check was already issued by the parser, so I deleted it with no change to the tests.