Elide import equals in transpileModule if referenced only by export type - #49664
Merged
Andrew Branch (andrewbranch) merged 3 commits intoJul 5, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
|
|
Andrew Branch (andrewbranch)
requested changes
Jun 24, 2022
Andrew Branch (andrewbranch)
requested changes
Jul 1, 2022
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
This looks right, but could you also add a test and check for export { type IFoo }? It looks like that construct probably needs to be fixed too. Thanks!
Andrew Branch (andrewbranch)
approved these changes
Jul 5, 2022
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49450
See investigation notes in issue. In short, it seems like the removal of the type only "import equals" declaration was not occurring because it relied on type information about the alias itself. We can still elide correctly under
transpileModuleby noticing when an export declaration is type only.