do not report use-before-declaration error in async IIFE initializer - #50199
Merged
Gabriela Araujo Britto (gabritto) merged 1 commit intoNov 2, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Nathan Shively-Sanders (sandersn)
requested review from
Gabriela Araujo Britto (gabritto) and
navya9singh
August 17, 2022 22:45
Gabriela Araujo Britto (gabritto)
approved these changes
Aug 25, 2022
Gabriela Araujo Britto (gabritto)
left a comment
Gabriela Araujo Britto (gabritto)
left a comment
Member
There was a problem hiding this comment.
Thanks! ✨
Member
|
Worth noting here that, as discussed in the original issue (#50123 (comment)), with this fix we will now allow (valid) cases like: const promise = (async () => {
await foo();
promise;
})()but also invalid ones like: const promise = (async () => {
promise;
await foo();
})() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50123