DOM update 2022/09/21

[sandersn]

Fixes #50099

[sandersn]

@typescript-bot run dt

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at d7bf787. You can monitor the build here.

[DanielRosenwasser]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at d7bf787. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at d7bf787. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at d7bf787. You can monitor the build here.

[DanielRosenwasser]

Approved - let's see if the tests find anything and revisit if they do.

[typescript-bot]

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50884/merge:

Something interesting changed - please have a look.

Details

puppeteer

tsconfig.lib.json

• [NEW] error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.
  • file:///mnt/ts_downloads/puppeteer/node_modules/@types/node/globals.d.ts#L72 in vendor/tsconfig.esm.json
  • file:///mnt/ts_downloads/puppeteer/node_modules/@types/node/globals.d.ts#L72 in compat/esm/tsconfig.json
  • file:///mnt/ts_downloads/puppeteer/node_modules/@types/node/globals.d.ts#L72 in vendor/tsconfig.cjs.json
  • file:///mnt/ts_downloads/puppeteer/node_modules/@types/node/globals.d.ts#L72 in compat/cjs/tsconfig.json
• [MISSING] error TS2307: Cannot find module '../generated/injected.js' or its corresponding type declarations.
  • src/common/IsolatedWorld.ts#L18 in src/tsconfig.esm.json
  • src/common/IsolatedWorld.ts#L18 in src/tsconfig.cjs.json
• [MISSING] error TS2307: Cannot find module '../generated/version.js' or its corresponding type declarations.
  • src/node/NodeWebSocketTransport.ts#L18 in src/tsconfig.esm.json
  • src/node/NodeWebSocketTransport.ts#L18 in src/tsconfig.cjs.json
• [MISSING] error TS2322: Type '"latest"' is not assignable to type '"1036745"'.
  • src/initializePuppeteer.ts#L37 in src/tsconfig.esm.json
  • src/initializePuppeteer.ts#L37 in src/tsconfig.cjs.json
• [MISSING] error TS2307: Cannot find module './generated/injected.js' or its corresponding type declarations.
  • src/types.ts#L59 in src/tsconfig.esm.json
  • src/types.ts#L59 in src/tsconfig.cjs.json
• [MISSING] error TS2307: Cannot find module './generated/version.js' or its corresponding type declarations.
  • src/types.ts#L60 in src/tsconfig.esm.json
  • src/types.ts#L60 in src/tsconfig.cjs.json

[typescript-bot]

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.