Skip to content

Avoid unnecessary buildInfo read if host supports caching it (avoids in --build scenario) and some reporting cleanup - #51403

Merged
Sheetal Nandi (sheetalkamat) merged 6 commits into
mainfrom
reportingCleanup
Nov 5, 2022
Merged

Avoid unnecessary buildInfo read if host supports caching it (avoids in --build scenario) and some reporting cleanup#51403
Sheetal Nandi (sheetalkamat) merged 6 commits into
mainfrom
reportingCleanup

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Nov 3, 2022

Copy link
Copy Markdown
Member

Cherry picked cleanup and fixes from #50293
Basically not picking unnecessary additions to report buildInfo size and read/write times

  1. Fixes issue where earlier PR (Report aggregate statistics for solution as well as some solution perf numbers #50267) forgot to clear the aggregate diagnostics in watch mode after reporting
  2. When manipulating bundle because the d.ts file didnt change, use cached buildInfo instead of reading it again and parsing if available. (This was discovered as part of Report buildInfo size in extendedDiagnostics #50293 and we already do this when reading old program from buildInfo but not when manipulating bundle)

[4:04:42 PM] Updating output of project '/TypeScript/src/tsserver/tsconfig.json'...

Memory used:        581215K
transformTime time:   0.01s
Source Map time:      0.35s
commentTime time:     0.00s
printTime time:       0.58s
Emit time:            0.90s
I/O Write time:       0.01s
Total time:           0.90s
Comment thread src/compiler/factory/nodeFactory.ts Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants