Fix Go To Source Definition in --moduleResolution bundler - #53613
Merged
andrewbranch merged 8 commits intoMar 31, 2023
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
marked this pull request as draft
March 31, 2023 20:19
andrewbranch
marked this pull request as ready for review
March 31, 2023 20:29
andrewbranch
requested review from
DanielRosenwasser,
jakebailey and
sheetalkamat
March 31, 2023 20:38
Member
Author
|
I’d really like to get this into a patch. It should be safe, since |
sheetalkamat
approved these changes
Mar 31, 2023
jakebailey
approved these changes
Mar 31, 2023
jakebailey
left a comment
jakebailey
left a comment
Member
There was a problem hiding this comment.
Seems good to me but CI is failing 😄
Member
Author
|
I’m trying to go too fast and thereby going slow 😅 |
Member
Author
|
@typescript-bot cherry-pick to release-5.0 |
Contributor
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Contributor
|
Hey @andrewbranch, I've opened #53617 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 31, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Apr 5, 2023
…e-5.0 (#53617) Co-authored-by: Andrew Branch <andrew@wheream.io>
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53617) Co-authored-by: Andrew Branch <andrew@wheream.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happened to notice that
requirewasn’t being followed while I was working on microsoft/vscode#178840