Exclude generic string-like types from intersection reduction

[Anders Hejlsberg (ahejlsberg)]

Fixes #57736.

[Anders Hejlsberg (ahejlsberg)]

TypeScript Bot (@typescript-bot) test top200
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

[TypeScript Bot (typescript-bot)]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top200	✅ Started	✅ Results
user test this	✅ Started	👀 Results
run dt	✅ Started	✅ Results
perf test this faster	✅ Started	👀 Results

[TypeScript Bot (typescript-bot)]

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/57751/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"
• 1 instance of "Unknown failure"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

• [MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
  • packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

[Ryan Cavanaugh (RyanCavanaugh)]

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.4

[TypeScript Bot (typescript-bot)]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick this to release-5.4	✅ Started	✅ Results

[TypeScript Bot (typescript-bot)]

Hey, Ryan Cavanaugh (@RyanCavanaugh)! I've created #57753 for you.

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/57751/merge:

Everything looks good!

[TypeScript Bot (typescript-bot)]

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

Metric	baseline	pr	Delta	Best	Worst	p-value
Angular - node (v18.15.0, x64)
Memory used	295,588k (± 0.00%)	295,595k (± 0.01%)	~	295,534k	295,617k	p=0.128 n=6
Parse Time	2.66s (± 0.00%)	2.66s (± 0.31%)	~	2.65s	2.67s	p=0.290 n=6
Bind Time	0.83s (± 0.76%)	0.83s (± 1.08%)	~	0.82s	0.84s	p=1.000 n=6
Check Time	8.21s (± 0.21%)	8.20s (± 0.53%)	~	8.14s	8.26s	p=0.469 n=6
Emit Time	7.13s (± 0.31%)	7.14s (± 0.18%)	~	7.13s	7.16s	p=0.405 n=6
Total Time	18.83s (± 0.15%)	18.83s (± 0.24%)	~	18.77s	18.90s	p=1.000 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used	192,039k (± 0.74%)	192,133k (± 0.72%)	~	191,383k	194,925k	p=0.471 n=6
Parse Time	1.36s (± 0.89%)	1.35s (± 0.87%)	~	1.33s	1.36s	p=0.438 n=6
Bind Time	0.72s (± 0.00%)	0.72s (± 0.00%)	~	0.72s	0.72s	p=1.000 n=6
Check Time	9.29s (± 0.26%)	9.34s (± 0.48%)	~	9.30s	9.42s	p=0.077 n=6
Emit Time	2.60s (± 0.38%)	2.60s (± 0.21%)	~	2.60s	2.61s	p=0.232 n=6
Total Time	13.98s (± 0.21%)	14.01s (± 0.33%)	~	13.97s	14.10s	p=0.146 n=6
Monaco - node (v18.15.0, x64)
Memory used	347,313k (± 0.00%)	347,339k (± 0.01%)	~	347,299k	347,402k	p=0.066 n=6
Parse Time	2.49s (± 0.33%)	2.48s (± 0.21%)	~	2.48s	2.49s	p=0.523 n=6
Bind Time	0.93s (± 0.44%)	0.93s (± 0.56%)	~	0.92s	0.93s	p=0.595 n=6
Check Time	6.92s (± 0.25%)	6.95s (± 0.40%)	~	6.90s	6.98s	p=0.193 n=6
Emit Time	4.06s (± 0.46%)	4.06s (± 0.43%)	~	4.04s	4.09s	p=0.461 n=6
Total Time	14.40s (± 0.20%)	14.41s (± 0.25%)	~	14.37s	14.47s	p=0.747 n=6
TFS - node (v18.15.0, x64)
Memory used	302,769k (± 0.00%)	302,778k (± 0.01%)	~	302,749k	302,833k	p=0.809 n=6
Parse Time	2.01s (± 0.92%)	2.02s (± 0.51%)	~	2.00s	2.03s	p=1.000 n=6
Bind Time	1.00s (± 1.37%)	1.01s (± 1.45%)	~	0.99s	1.03s	p=0.458 n=6
Check Time	6.32s (± 0.24%)	6.33s (± 0.36%)	~	6.31s	6.36s	p=0.563 n=6
Emit Time	3.60s (± 0.76%)	3.60s (± 0.72%)	~	3.56s	3.64s	p=0.936 n=6
Total Time	12.93s (± 0.27%)	12.96s (± 0.28%)	~	12.93s	13.03s	p=0.293 n=6
material-ui - node (v18.15.0, x64)
Memory used	511,247k (± 0.00%)	511,249k (± 0.00%)	~	511,232k	511,282k	p=0.936 n=6
Parse Time	2.65s (± 0.55%)	2.66s (± 0.34%)	~	2.65s	2.67s	p=0.363 n=6
Bind Time	0.98s (± 1.05%)	0.99s (± 0.76%)	~	0.98s	1.00s	p=0.351 n=6
Check Time	17.30s (± 0.48%)	17.31s (± 0.47%)	~	17.17s	17.39s	p=0.872 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.93s (± 0.33%)	20.96s (± 0.40%)	~	20.81s	21.04s	p=0.520 n=6
mui-docs - node (v18.15.0, x64)
Memory used	1,789,396k (± 0.00%)	1,789,436k (± 0.00%)	+40k (+ 0.00%)	1,789,393k	1,789,493k	p=0.031 n=6
Parse Time	6.63s (± 0.33%)	6.63s (± 0.66%)	~	6.58s	6.70s	p=0.871 n=6
Bind Time	2.39s (± 0.34%)	2.40s (± 0.23%)	~	2.39s	2.40s	p=0.054 n=6
Check Time	59.01s (± 0.46%)	58.98s (± 0.52%)	~	58.59s	59.29s	p=0.748 n=6
Emit Time	0.16s (± 3.16%)	0.17s (± 2.42%)	~	0.16s	0.17s	p=0.112 n=6
Total Time	68.19s (± 0.41%)	68.17s (± 0.48%)	~	67.75s	68.54s	p=0.936 n=6
self-build-src - node (v18.15.0, x64)
Memory used	2,394,906k (± 0.02%)	2,394,683k (± 0.02%)	~	2,394,004k	2,395,332k	p=0.810 n=6
Parse Time	5.02s (± 0.68%)	5.02s (± 1.18%)	~	4.94s	5.11s	p=0.810 n=6
Bind Time	1.89s (± 0.70%)	1.90s (± 0.88%)	~	1.88s	1.92s	p=0.227 n=6
Check Time	33.60s (± 0.20%)	33.58s (± 0.22%)	~	33.47s	33.70s	p=0.471 n=6
Emit Time	2.69s (± 1.96%)	2.67s (± 1.40%)	~	2.60s	2.71s	p=1.000 n=6
Total Time	43.21s (± 0.19%)	43.18s (± 0.29%)	~	43.02s	43.31s	p=0.689 n=6
self-compiler - node (v18.15.0, x64)
Memory used	414,600k (± 0.01%)	414,624k (± 0.01%)	~	414,596k	414,671k	p=0.229 n=6
Parse Time	2.81s (± 0.58%)	2.82s (± 0.83%)	~	2.79s	2.85s	p=0.935 n=6
Bind Time	1.06s (± 0.71%)	1.07s (± 0.38%)	~	1.06s	1.07s	p=0.100 n=6
Check Time	15.20s (± 0.43%)	15.20s (± 0.18%)	~	15.18s	15.24s	p=0.805 n=6
Emit Time	1.13s (± 0.92%)	1.13s (± 0.74%)	~	1.12s	1.14s	p=0.672 n=6
Total Time	20.20s (± 0.29%)	20.21s (± 0.25%)	~	20.17s	20.29s	p=0.467 n=6
vscode - node (v18.15.0, x64)
Memory used	2,871,177k (± 0.00%)	2,871,171k (± 0.00%)	~	2,870,908k	2,871,270k	p=0.873 n=6
Parse Time	10.78s (± 0.36%)	10.78s (± 0.23%)	~	10.75s	10.82s	p=0.747 n=6
Bind Time	3.46s (± 0.54%)	3.46s (± 0.30%)	~	3.44s	3.47s	p=0.934 n=6
Check Time	61.11s (± 0.43%)	61.16s (± 0.64%)	~	60.77s	61.76s	p=1.000 n=6
Emit Time	16.89s (± 8.12%)	16.89s (± 8.23%)	~	16.16s	19.72s	p=0.936 n=6
Total Time	92.24s (± 1.73%)	92.28s (± 1.84%)	~	91.29s	95.69s	p=1.000 n=6
webpack - node (v18.15.0, x64)
Memory used	404,905k (± 0.01%)	404,865k (± 0.01%)	~	404,809k	404,928k	p=0.261 n=6
Parse Time	3.23s (± 0.26%)	3.25s (± 0.42%)	~	3.23s	3.27s	p=0.109 n=6
Bind Time	1.40s (± 0.95%)	1.41s (± 0.98%)	~	1.38s	1.42s	p=0.323 n=6
Check Time	14.06s (± 0.36%)	14.05s (± 0.28%)	~	14.01s	14.10s	p=0.809 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	18.70s (± 0.23%)	18.71s (± 0.28%)	~	18.64s	18.78s	p=0.688 n=6
xstate - node (v18.15.0, x64)
Memory used	513,189k (± 0.01%)	513,176k (± 0.01%)	~	513,126k	513,220k	p=0.810 n=6
Parse Time	3.27s (± 0.25%)	3.29s (± 0.23%)	+0.01s (+ 0.46%)	3.28s	3.30s	p=0.015 n=6
Bind Time	1.54s (± 0.41%)	1.54s (± 0.26%)	~	1.54s	1.55s	p=0.673 n=6
Check Time	2.87s (± 0.64%)	2.85s (± 0.61%)	~	2.84s	2.88s	p=0.222 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 4.99%)	~	0.08s	0.09s	p=0.405 n=6
Total Time	7.77s (± 0.19%)	7.77s (± 0.24%)	~	7.75s	7.79s	p=0.624 n=6

System info unknown

Hosts

• node (v18.15.0, x64)

Scenarios

• Angular - node (v18.15.0, x64)
• Compiler-Unions - node (v18.15.0, x64)
• Monaco - node (v18.15.0, x64)
• TFS - node (v18.15.0, x64)
• material-ui - node (v18.15.0, x64)
• mui-docs - node (v18.15.0, x64)
• self-build-src - node (v18.15.0, x64)
• self-compiler - node (v18.15.0, x64)
• vscode - node (v18.15.0, x64)
• webpack - node (v18.15.0, x64)
• xstate - node (v18.15.0, x64)

Benchmark	Name	Iterations
Current	pr	6
Baseline	baseline	6

Developer Information:

Download Benchmarks

[Anders Hejlsberg (ahejlsberg)]

Tests and performance are all clean. I think this is ready to merge.