Added affectsSourceFile to importHelpers and jsxImportSource

[Armando Aguirre (armanio123)]

Fixes #59168 (comment)

The issue happens in a project containing nested projects. One of them defines "importHelpers": true, while the root config doesn't.

In this scenario, depending on the order the files are opened an incorrect checker is used causing to hit the assert: Debug Failure. False expression: Expected sourceFile.imports[0] to be the synthesized tslib import.

[Sheetal Nandi (sheetalkamat)]

This is good but test case would be better

[Daniel Rosenwasser (DanielRosenwasser)]

Is this due to #58654? Does the change need to be cherry-picked to release-5.5? (CC Gabriela Araujo Britto (@gabritto))

[Andrew Branch (andrewbranch)]

The inconsistency was always there, but the debug assert is new in #58451, so yes, a cherry-pick would be good

[Gabriela Araujo Britto (gabritto)]

Is this due to #58654? Does the change need to be cherry-picked to release-5.5? (CC Gabriela Araujo Britto (@gabritto))

Adding to what Andrew said, #58654 makes us call the function with the failed assertion for potentially every file in a project instead of once per checker.

[Andrew Branch (andrewbranch)]

Also FWIW, the reason we're not seeing user reports about this is you need a project references scenario where two projects contain the same source file and differ in compiler options only in importHelpers, and it's dependent on project creation order (the one without importHelpers has to create the shared source file).

[Sheetal Nandi (sheetalkamat)]

Pls fix formatting

[Andrew Branch (andrewbranch)]

TypeScript Bot (@typescript-bot) cherry-pick to release-5.5

[TypeScript Bot (typescript-bot)]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
cherry-pick to release-5.5	✅ Started	✅ Results

[TypeScript Bot (typescript-bot)]

Hey, Andrew Branch (@andrewbranch)! I've created #59231 for you.