Switch coverage image from ubuntu-22.04 to mariner-2.0 by HannahOshlag · Pull Request #60541 · microsoft/TypeScript

Hannah Oshlag (HannahOshlag) · 2024-11-19T20:00:33Z

Fixes #

TypeScript Bot (typescript-bot) · 2024-11-19T20:00:38Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Hannah Oshlag (HannahOshlag) · 2024-11-19T20:01:01Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-11-19T20:01:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-11-19T20:21:16Z

@noshlag Here are the results of running the user tests with tsc comparing main and refs/pull/60541/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2024-11-19T20:22:16Z

Hey @noshlag, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-11-19T20:49:45Z

@noshlag
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,242k (± 0.96%)}	_{194,873k (± 1.03%)}	_~	_193,021k	_196,885k	_{p=0.575 n=6}
_{Parse Time}	_{1.32s (± 0.62%)}	_{1.31s (± 0.92%)}	_~	_1.29s	_1.32s	_{p=0.599 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.82s (± 0.57%)}	_{9.79s (± 0.52%)}	_~	_9.73s	_9.85s	_{p=0.471 n=6}
_{Emit Time}	_{2.73s (± 0.98%)}	_{2.74s (± 0.58%)}	_~	_2.71s	_2.75s	_{p=0.684 n=6}
_{Total Time}	_{14.58s (± 0.46%)}	_{14.56s (± 0.40%)}	_~	_14.48s	_14.63s	_{p=0.630 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,006k (± 0.00%)}	_{1,226,027k (± 0.00%)}	_~	_1,225,965k	_1,226,099k	_{p=0.630 n=6}
_{Parse Time}	_{6.65s (± 0.63%)}	_{6.64s (± 0.99%)}	_~	_6.54s	_6.74s	_{p=0.808 n=6}
_{Bind Time}	_{1.89s (± 0.29%)}	_{1.89s (± 0.40%)}	_~	_1.88s	_1.90s	_{p=0.476 n=6}
_{Check Time}	_{31.96s (± 0.26%)}	_{31.99s (± 0.29%)}	_~	_31.87s	_32.10s	_{p=0.630 n=6}
_{Emit Time}	_{15.19s (± 0.30%)}	_{15.20s (± 0.46%)}	_~	_15.10s	_15.31s	_{p=0.688 n=6}
_{Total Time}	_{55.69s (± 0.17%)}	_{55.71s (± 0.35%)}	_~	_55.42s	_55.87s	_{p=0.470 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,498,273	_2,498,273	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,637	_908,637	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,315,878k (± 0.00%)}	_{2,315,893k (± 0.00%)}	_~	_2,315,852k	_2,315,972k	_{p=0.748 n=6}
_{Parse Time}	_{9.31s (± 0.27%)}	_{9.29s (± 0.24%)}	_~	_9.27s	_9.33s	_{p=0.256 n=6}
_{Bind Time}	_{2.17s (± 0.24%)}	_2.17s	_~	_~	_~	_{p=0.174 n=6}
_{Check Time}	_{74.83s (± 0.42%)}	_{74.90s (± 0.27%)}	_~	_74.61s	_75.18s	_{p=0.575 n=6}
_{Emit Time}	_{0.28s (± 3.68%)}	_{0.29s (± 2.85%)}	_~	_0.28s	_0.30s	_{p=0.865 n=6}
_{Total Time}	_{86.60s (± 0.38%)}	_{86.65s (± 0.24%)}	_~	_86.33s	_86.93s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,546	_266,546	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,354,414k (± 0.04%)}	_{2,414,437k (± 6.14%)}	_~	_2,353,523k	_2,717,306k	_{p=0.689 n=6}
_{Parse Time}	_{5.22s (± 0.65%)}	_{5.24s (± 2.32%)}	_~	_5.11s	_5.45s	_{p=0.689 n=6}
_{Bind Time}	_{1.79s (± 0.89%)}	_{1.77s (± 1.41%)}	_~	_1.73s	_1.80s	_{p=0.419 n=6}
_{Check Time}	_{35.24s (± 0.13%)}	_{35.18s (± 0.74%)}	_~	_34.69s	_35.40s	_{p=0.810 n=6}
_{Emit Time}	_{2.96s (± 2.11%)}	_{2.97s (± 1.18%)}	_~	_2.93s	_3.02s	_{p=0.872 n=6}
_{Total Time}	_{45.22s (± 0.17%)}	_{45.16s (± 0.40%)}	_~	_44.86s	_45.36s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,546	_266,546	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,028,967k (± 9.78%)}	_{3,028,619k (± 9.77%)}	_~	_2,424,069k	_3,150,050k	_{p=0.298 n=6}
_{Parse Time}	_{8.66s (± 1.24%)}	_{8.70s (± 0.99%)}	_~	_8.56s	_8.80s	_{p=0.471 n=6}
_{Bind Time}	_{2.65s (± 1.74%)}	_{2.63s (± 1.24%)}	_~	_2.59s	_2.68s	_{p=0.423 n=6}
_{Check Time}	_{53.19s (± 0.45%)}	_{53.13s (± 0.18%)}	_~	_53.04s	_53.27s	_{p=0.575 n=6}
_{Emit Time}	_{4.31s (± 2.85%)}	_{4.38s (± 2.74%)}	_~	_4.30s	_4.61s	_{p=0.230 n=6}
_{Total Time}	_{68.83s (± 0.43%)}	_{68.83s (± 0.19%)}	_~	_68.73s	_69.07s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,223	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,607	_106,607	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,834k (± 0.02%)}	_{439,769k (± 0.01%)}	_~	_439,716k	_439,801k	_{p=0.378 n=6}
_{Parse Time}	_{3.54s (± 0.99%)}	_{3.55s (± 1.38%)}	_~	_3.49s	_3.62s	_{p=0.809 n=6}
_{Bind Time}	_{1.33s (± 1.06%)}	_{1.33s (± 0.92%)}	_~	_1.31s	_1.34s	_{p=0.564 n=6}
_{Check Time}	_{18.98s (± 0.50%)}	_{18.98s (± 0.48%)}	_~	_18.85s	_19.10s	_{p=0.873 n=6}
_{Emit Time}	_{1.54s (± 1.57%)}	_{1.52s (± 0.50%)}	_~	_1.51s	_1.53s	_{p=0.210 n=6}
_{Total Time}	_{25.38s (± 0.31%)}	_{25.36s (± 0.44%)}	_~	_25.22s	_25.53s	_{p=0.575 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,649k (± 0.04%)}	_{371,633k (± 0.02%)}	_~	_371,588k	_371,759k	_{p=0.936 n=6}
_{Parse Time}	_{2.88s (± 0.74%)}	_{2.90s (± 0.64%)}	_~	_2.87s	_2.92s	_{p=0.289 n=6}
_{Bind Time}	_{1.59s (± 1.32%)}	_{1.59s (± 1.34%)}	_~	_1.57s	_1.63s	_{p=0.934 n=6}
_{Check Time}	_{16.48s (± 0.40%)}	_{16.49s (± 0.28%)}	_~	_16.41s	_16.55s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.34%)}	_{20.98s (± 0.16%)}	_~	_20.92s	_21.01s	_{p=0.198 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,154,489	_3,154,489	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,087,206	_1,087,206	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,236,915k (± 0.01%)}	_{3,237,049k (± 0.01%)}	_~	_3,236,402k	_3,237,474k	_{p=0.689 n=6}
_{Parse Time}	_{17.32s (± 0.35%)}	_{17.25s (± 0.40%)}	_~	_17.17s	_17.37s	_{p=0.077 n=6}
_{Bind Time}	_{5.42s (± 0.22%)}	_{5.45s (± 0.34%)}	_{+0.03s (+ 0.46%)}	_5.42s	_5.47s	_{p=0.033 n=6}
_{Check Time}	_{105.12s (± 1.79%)}	_{104.18s (± 1.50%)}	_~	_103.00s	_107.25s	_{p=0.298 n=6}
_{Emit Time}	_{33.24s (± 5.21%)}	_{32.96s (± 1.40%)}	_~	_32.09s	_33.47s	_{p=0.170 n=6}
_{Total Time}	_{161.12s (± 0.61%)}	_{159.84s (± 0.96%)}	_~	_158.79s	_162.87s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,598	_288,598	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,107	_117,107	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,024k (± 0.03%)}	_{440,947k (± 0.04%)}	_~	_440,759k	_441,205k	_{p=0.298 n=6}
_{Parse Time}	_{4.10s (± 1.25%)}	_{4.07s (± 0.95%)}	_~	_4.04s	_4.14s	_{p=0.334 n=6}
_{Bind Time}	_{1.75s (± 0.79%)}	_{1.73s (± 1.70%)}	_~	_1.70s	_1.76s	_{p=0.567 n=6}
_{Check Time}	_{18.88s (± 0.32%)}	_{18.88s (± 0.40%)}	_~	_18.81s	_19.01s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.01s (±109.43%)}	_~	_0.00s	_0.01s	_{p=0.282 n=6}
_{Total Time}	_{24.73s (± 0.44%)}	_{24.68s (± 0.36%)}	_~	_24.57s	_24.82s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,924k (± 0.01%)}	_{491,892k (± 0.01%)}	_~	_491,817k	_491,928k	_{p=0.298 n=6}
_{Parse Time}	_{3.42s (± 0.60%)}	_{3.42s (± 0.50%)}	_~	_3.39s	_3.44s	_{p=1.000 n=6}
_{Bind Time}	_{1.17s (± 1.16%)}	_{1.16s (± 1.14%)}	_~	_1.14s	_1.18s	_{p=0.164 n=6}
_{Check Time}	_{19.61s (± 0.42%)}	_{19.58s (± 0.33%)}	_~	_19.48s	_19.65s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.20s (± 0.35%)}	_{24.15s (± 0.25%)}	_~	_24.06s	_24.22s	_{p=0.422 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-11-19T22:02:20Z

@noshlag Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60541/merge:

Everything looks good!

Jake Bailey (jakebailey)

This is all working now.

Jake Bailey (jakebailey) · 2024-12-05T23:17:24Z

Merging before full CI just because I know this works and I just dropped ubuntu from the pool (so other PRs would have hung).

Switching Image from Ubuntu-22.04 to Mariner-2.0

d4859c0

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 19, 2024

Hannah Oshlag (HannahOshlag) requested a review from Jake Bailey (jakebailey) November 19, 2024 20:09

Jake Bailey (jakebailey) closed this Dec 4, 2024

Jake Bailey (jakebailey) reopened this Dec 4, 2024

Jake Bailey (jakebailey) closed this Dec 5, 2024

Jake Bailey (jakebailey) reopened this Dec 5, 2024

Jake Bailey (jakebailey) closed this Dec 5, 2024

Jake Bailey (jakebailey) reopened this Dec 5, 2024

Jake Bailey (jakebailey) approved these changes Dec 5, 2024

View reviewed changes

Jake Bailey (jakebailey) changed the title ~~Switching Image from Ubuntu-22.04 to Mariner-2.0~~ Switch coverage image from ubuntu-22.04 to mariner-2.0 Dec 5, 2024

Jake Bailey (jakebailey) merged commit edd278a into main Dec 5, 2024

Jake Bailey (jakebailey) deleted the naoshl/pipelines/ubuntu-to-mariner branch December 5, 2024 23:16

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025

Navigation Menu

Uh oh!

Switch coverage image from ubuntu-22.04 to mariner-2.0 - #60541

Switch coverage image from ubuntu-22.04 to mariner-2.0#60541
Jake Bailey (jakebailey) merged 1 commit into
mainfrom
naoshl/pipelines/ubuntu-to-mariner

Hannah Oshlag (HannahOshlag) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

Hannah Oshlag (HannahOshlag) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

Jake Bailey (jakebailey) left a comment

Uh oh!

Jake Bailey (jakebailey) commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Hannah Oshlag (HannahOshlag) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

Hannah Oshlag (HannahOshlag) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 19, 2024

Uh oh!

Jake Bailey (jakebailey) left a comment

Choose a reason for hiding this comment

Uh oh!

Jake Bailey (jakebailey) commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Nov 19, 2024 •

edited

Loading