Cache started nonexistent property error checks to prevent reentrancy in the check - #60683
Merged
Wesley Wigham (weswigham) merged 1 commit intoDec 4, 2024
Conversation
Wesley Wigham (weswigham)
requested review from
Gabriela Araujo Britto (gabritto) and
Nathan Shively-Sanders (sandersn)
December 4, 2024 20:55
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Gabriela Araujo Britto (gabritto)
approved these changes
Dec 4, 2024
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-5.7 |
Contributor
TypeScript Bot (typescript-bot)
pushed a commit
that referenced
this pull request
Dec 4, 2024
Contributor
|
Hey, Ryan Cavanaugh (@RyanCavanaugh)! I've created #60686 for you. |
|
Will give this a spin on our full repo to test #60564 tomorrow morning 👍 thanks for the fix! |
Ryan Cavanaugh (RyanCavanaugh)
pushed a commit
that referenced
this pull request
Dec 5, 2024
…e-5.7 (#60686) Co-authored-by: Wesley Wigham <wewigham@microsoft.com>
|
Confirmed that the issue reproduces in 5.8.0-dev.20241204 and is no longer reproducible in 5.8.0-dev.20241205. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60564
None of the expression types made while looking at the structure for this check are cached (courtesy of using
getRegularTypeOfExpressioninstead ofcheckExpressionCachedinserializeTypeOfExpression, which is itself done to handle freshness correctly), so the diagnostic check itself needs to be cached to prevent reentrancy when reporting on a circularly referential structure.