Skip to content

Reenable fail-fast in merge queues - #62856

Merged
jakebailey merged 1 commit into
microsoft:mainfrom
jakebailey:jabaile/merge-group-fail-fast
Dec 8, 2025
Merged

Reenable fail-fast in merge queues#62856
jakebailey merged 1 commit into
microsoft:mainfrom
jakebailey:jabaile/merge-group-fail-fast

Conversation

@jakebailey

Copy link
Copy Markdown
Member

If a job fails in a merge queue, it's either a platform flake, or a runtime merge conflict. Don't bother running all jobs and let it quit out as early as possible.

Copilot AI review requested due to automatic review settings December 8, 2025 19:00
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Dec 8, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 8, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables fail-fast behavior specifically for merge queue runs to optimize CI execution time. When a test fails in a merge queue, it indicates either a platform flake or a runtime merge conflict, making it inefficient to continue running remaining jobs. The change uses a conditional expression to enable fail-fast only for merge_group events while keeping it disabled for regular pull requests and pushes, allowing developers to see all test failures during normal development.

Key Changes

  • Modified the fail-fast strategy to conditionally enable based on the GitHub event type
  • Fail-fast is now enabled (true) only for merge_group events
  • Fail-fast remains disabled (false) for regular CI events like pull_request and push

@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Dec 8, 2025
@jakebailey jakebailey closed this Dec 8, 2025
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Dec 8, 2025
@jakebailey jakebailey reopened this Dec 8, 2025
@github-project-automation github-project-automation Bot moved this from Done to Not started in PR Backlog Dec 8, 2025
@jakebailey
jakebailey merged commit c21f73f into microsoft:main Dec 8, 2025
45 of 68 checks passed
@github-project-automation github-project-automation Bot moved this from Not started to Done in PR Backlog Dec 8, 2025
@jakebailey
jakebailey deleted the jabaile/merge-group-fail-fast branch December 8, 2025 20:14
@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants